-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix items between lists #1936
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/6F33HfppZUivANHrhsUD9SbwzyDk |
Thanks so much for looking at this so quickly. I was wondering if there was any ETA on when this fix might make it into a release? |
@jackw it should be just a few days until this is released. Once we have two approvals from team members we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'm ok to merge this, but this has become another area with lots of checks for the pedantic option threaded throughout. Is there a point when it would be more legible (and maybe faster) having all the pedantic logic together behind a single check, even if there is a bit of code reuse? |
Possibly not. I can't seem to find the conversation but I recall someone mentioning working on a whole different lexer and parser for I tend to prefer less code reuse so we don't have to remember to change the code in multiple places when updating it. |
## [2.0.1](v2.0.0...v2.0.1) (2021-02-27) ### Bug Fixes * fix items between lists ([#1936](#1936)) ([46cdfc1](46cdfc1))
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Marked version: 2.0.0
Markdown flavor: Markdown.pl, CommonMark, GitHub Flavored Markdown
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.