fix: use rollup to output js files #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 3, 2023
Closed
|
@styfle any issue with merging this? |
styfle
reviewed
Aug 7, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es2021", | |||
| "target": "es2022", | |||
There was a problem hiding this comment.
I believe we chose ES2021 to support Node.js 16
There was a problem hiding this comment.
Es 2021 doesn't support private methods that we already use. This still passes with node 16 with 2022.
styfle
reviewed
Aug 7, 2023
| "test:update": "node test/update-specs.js", | ||
| "rules": "node test/rules.js", | ||
| "bench": "npm run build && node test/bench.js", | ||
| "lint": "eslint --fix .", | ||
| "type-check": "tsc", |
There was a problem hiding this comment.
Maybe I'm missing it, but where do we run tsc using the root tsconfig.json? Did you verify that a type error will fail the build?
There was a problem hiding this comment.
Yes rollup handles running tsc and will fail to build on typescript error
styfle
approved these changes
Aug 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
## [7.0.1](v7.0.0...v7.0.1) (2023-08-07) ### Bug Fixes * use rollup to output js files ([#2916](#2916)) ([610bc45](610bc45))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: v6.0.0
Description
Fix umd output by removing tsup and adding rollup
Add umd-test to check umd adds global marked
Contributor
Committer
In most cases, this should be a different person than the contributor.