-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow async option to dictate type returned #3341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UziTech
force-pushed
the
marked-async-type
branch
from
June 25, 2024 04:30
5aea8d3
to
b611885
Compare
UziTech
force-pushed
the
marked-async-type
branch
from
July 19, 2024 07:23
b611885
to
d46feab
Compare
Deployment failed with the following error:
|
UziTech
force-pushed
the
marked-async-type
branch
from
July 28, 2024 18:00
efbb640
to
eaa9f03
Compare
@styfle @calculuschild Can I get an approval to merge this and release marked v14 |
UziTech
changed the title
BREAKING CHANGE: allow async option to dictate type returned
fix: allow async option to dictate type returned
Aug 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
# [14.0.0](v13.0.3...v14.0.0) (2024-08-07) ### Bug Fixes * allow async option to dictate type returned ([#3341](#3341)) ([b5a5004](b5a5004)) * Remove useNewRenderer ([#3342](#3342)) ([e64f226](e64f226)) ### BREAKING CHANGES * Remove old renderer * throw an error if `async: false` is set when an extension sets `async: true`
This was referenced Sep 23, 2024
This was referenced Sep 24, 2024
This was referenced Sep 25, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: v13
Description
BREAKING CHANGE: throw an error if
async: false
is sent with parse options when using an async extension.This allows us to overload the parse method when the
async
option is set.closes #3116
Contributor
Committer
In most cases, this should be a different person than the contributor.