Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix recursion-like stack overflow error caused by the old render… #3380

Merged
merged 2 commits into from
Jul 28, 2024
Merged

fix: fix recursion-like stack overflow error caused by the old render… #3380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f50094
fix: fix recursion-like stack overflow error caused by the old render…
Jul 24, 2024
b0779c6
refactor: move out old renderer method
Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class Marked {
renderer[rendererProp] = (...args: unknown[]) => {
if (!pack.useNewRenderer) {
// TODO: Remove this in next major version
rendererFunc = this.#convertRendererFunction(rendererFunc, rendererProp, renderer) as GenericRendererFunction;
rendererFunc = this.#convertRendererFunction(pack.renderer![rendererProp] as GenericRendererFunction, rendererProp, renderer) as GenericRendererFunction;
}
UziTech marked this conversation as resolved.
Show resolved Hide resolved
let ret = rendererFunc.apply(renderer, args);
if (ret === false) {
Expand Down