Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow key-value options to be passed in for harmonization flows in UI #713

Merged
merged 4 commits into from
Feb 2, 2018

Conversation

wooldridge
Copy link
Contributor

The features allows the user to pass in a number of key-value options with a harmonize flow.
The key-value list is built as a configurable Angular component.
Harmonization flow options in the UI are persisted in local storage.
Also fixes marklogic/datahub-central#1078.

Adds select-key-values component for displaying input boxes for entry
Includes controls for adding and removing inputs
Persists options (and other settings) in local storage
Option removal is now persisted.
Adds event emitter for remove event (also for add event).
@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

@marklogic-builder
Copy link
Contributor

Jenkins Build successful
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/20
509 tests run, 0 skipped, 0 failed.

Copy link
Contributor

@aebadirad aebadirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the reusability of the key/value pairs and how easy it is to add/remove them from the UI.

@aebadirad aebadirad merged commit c1ede2a into Marklogic-retired:develop Feb 2, 2018
@wooldridge wooldridge deleted the DHFPROD-167 branch May 11, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants