Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 3 #21

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Vite 3 #21

merged 5 commits into from
Jul 12, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Improve support for Vite 3
  • Fix issue with linked: false server only builds attempting to render assets
  • Some refactoring.
  • Dev config improvements

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #21 (bfa3ce8) into main (d5b5cb2) will increase coverage by 5.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   83.43%   88.97%   +5.54%     
==========================================
  Files           6        6              
  Lines         344      272      -72     
  Branches       89       86       -3     
==========================================
- Hits          287      242      -45     
+ Misses         49       23      -26     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
src/index.ts 93.92% <100.00%> (+4.98%) ⬆️
src/manifest-generator.ts 93.10% <0.00%> (-1.35%) ⬇️
src/render-assets-transform.ts 100.00% <0.00%> (ø)
src/serializer.ts 82.14% <0.00%> (+7.14%) ⬆️
src/esbuild-plugin.ts 52.17% <0.00%> (+15.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b5cb2...bfa3ce8. Read the comment docs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: bfa3ce8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 31688b4 into main Jul 12, 2022
@DylanPiercey DylanPiercey deleted the vite-3 branch July 12, 2022 20:41
@github-actions github-actions bot mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants