Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change server type for vite 5 change #93

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

sapphi-red
Copy link
Contributor

Description

Make testPage function to accept http.Server | Http2SecureServer instead of http.Server.

Motivation and Context

This PR fixes the type incompatibility with Vite 5.

related: vitejs/vite#14834

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 2828947

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented Nov 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sapphi-red / name: 翠 / green (2828947)

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978db3f) 76.53% compared to head (2828947) 76.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files           9        9           
  Lines         537      537           
  Branches      120      120           
=======================================
  Hits          411      411           
  Misses         81       81           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq merged commit 04504ce into marko-js:main Nov 7, 2023
10 of 11 checks passed
@sapphi-red sapphi-red deleted the fix/vite5-server-type branch November 8, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants