Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove deprecated 'initialValue' from sanitizeInputRestProps #10221

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

afilp
Copy link
Contributor

@afilp afilp commented Sep 18, 2024

Problem

I think (not 100% sure) that 'initialValue' is deprecated so it should also be removed from here?

Solution

Describe the solution this PR implements

How To Test

Describe the steps required to test the changes

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@fzaninotto
Copy link
Member

fzaninotto commented Sep 18, 2024

That's right, initialValue isn't supported since v4: https://github.com/marmelab/react-admin/blob/4.x/docs/Upgrade.md#initalvalue-and-defaultvalue-have-been-merged-into-defaultvalue

Would you mind looking for other remaining instances of the same prop in sanitizers to clean them up, too?

@afilp
Copy link
Contributor Author

afilp commented Sep 18, 2024

I will be glad to help the great react-admin team!

I will need some time though to check, as I am in a pressure to create some features. Thanks.

@fzaninotto fzaninotto merged commit ad33577 into marmelab:master Oct 29, 2024
13 checks passed
@fzaninotto
Copy link
Member

Thanks

@fzaninotto fzaninotto added this to the 5.3.2 milestone Oct 29, 2024
@slax57 slax57 changed the title Remove deprecated 'initialValue' from sanitizeInputRestProps Fix: Remove deprecated 'initialValue' from sanitizeInputRestProps Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants