Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <DateInput> and <DateTimeInput> do not react to form changes #10335

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Nov 7, 2024

Problem

<DateInput> and <DateTimeInput> do not react to form changes. For instance if you use react-hook-form hooks to set the value.

Fixes #10320

Solution

Make sure we update the internal value when it changes from outside.

How To Test

There are two new stories and matching tests:

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
    - [ ] The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added RFR Ready For Review WIP Work In Progress and removed RFR Ready For Review labels Nov 7, 2024
@fzaninotto fzaninotto merged commit 4f5f865 into master Nov 8, 2024
15 checks passed
@fzaninotto fzaninotto deleted the fix-date-inputs-external-changes branch November 8, 2024 12:23
@fzaninotto fzaninotto added this to the 5.3.3 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateInput and DateTimeInput not updating value in UI
2 participants