Follow zoom factor in parent window from <iframe> #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When presenting Marpit deck within iframe, our polyfill cannot follow the zoom factor in the parent window. Safari always treats the scaling factor for the slide deck inside frames as 1.
Marp CLI is actually exporting HTML that has a presenter view with the DOM structure like that. The zoom level in browser is important for users to read preseter notes in bigger font.
So I've improved to recognize the zoom factor in the parent frame only if both windows are using polyfill and the child frame can access to the parent safely. (they must have same-origin)
This patch would not resolve all use cases, but at least enough to fix problem for ours tools.