Stop using asdict to handle dataclasses #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
added
type: bug
wjsi
added a commit
to wjsi/mars
that referenced
this pull request
Oct 28, 2021
qinxuye
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Stop using std function
dataclasses.asdictto handle dataclasses as it usesdeepcopyfor non-collection objects, seehttps://github.com/python/cpython/blob/0a68b3603fbc0aaf9eeb8ce8b42b78d6fa7cfa78/Lib/dataclasses.py#L1273
Related issue number