Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Series.median() #2566

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Support Series.median() #2566

merged 2 commits into from
Nov 2, 2021

Conversation

perfumescent
Copy link
Contributor

@perfumescent perfumescent commented Oct 30, 2021 •
edited by qinxuye
Loading

What do these changes do?

Support Series.median() plus testings

Related issue number

Resolves #1345

Series.median() is mainly supported by tensor.statistics.median based on tensor.statistics.quantile

In addition to the parameters from tensor.statistics.median, I also added skipna for handling nan values just like pandas series()

4 test cases work fine.

However, I had trouble when Building Documentations.
I ran
make html
then
image
It seems my VM ubuntu suffers from its 8 GB memory. Is there a good way to solve this?

@qinxuye qinxuye added mod: dataframe to be backported Indicate that the PR need to be backported to stable branch type: feature New feature labels Nov 1, 2021
@qinxuye qinxuye added this to the v0.9.0a1 milestone Nov 1, 2021
@qinxuye
Copy link
Collaborator

qinxuye commented Nov 1, 2021

About the doc, if the resource is limited, you can submit a commit, it's well guaranteed by the CI.

BTW, I saw the failure: https://dev.azure.com/mars-project/mars/_build/results?buildId=1864&view=logs&jobId=435ca956-9126-505f-566f-fff31072e2ba&j=435ca956-9126-505f-566f-fff31072e2ba&t=456eced4-5f9f-56bd-1d85-873f530e72f3 , now we use black to format code, you can format the code to see if the checks can pass.

@perfumescent
Copy link
Contributor Author

About the doc, if the resource is limited, you can submit a commit, it's well guaranteed by the CI.

BTW, I saw the failure: https://dev.azure.com/mars-project/mars/_build/results?buildId=1864&view=logs&jobId=435ca956-9126-505f-566f-fff31072e2ba&j=435ca956-9126-505f-566f-fff31072e2ba&t=456eced4-5f9f-56bd-1d85-873f530e72f3 , now we use black to format code, you can format the code to see if the checks can pass.

new commit added

qinxuye
qinxuye approved these changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit bfe9a37 into mars-project:master Nov 2, 2021
hekaisheng
hekaisheng approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi pushed a commit to wjsi/mars that referenced this pull request Nov 2, 2021
@perfumescent @wjsi
Support Series.median() (mars-project#2566)
a1c9a59
@wjsi wjsi mentioned this pull request Nov 2, 2021
Merged
qinxuye pushed a commit that referenced this pull request Nov 2, 2021
@wjsi
[BACKPORT] Support Series.median() (#2566) (#2570)
51e03ad
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi Awaiting requested review from wjsi

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: feature New feature
Projects
None yet
Milestone
v0.9.0a1
Development

Successfully merging this pull request may close these issues.

Support Series.median()
4 participants
@perfumescent @qinxuye @hekaisheng @wjsi