Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use batched request to apply for slots #2601

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Use batched request to apply for slots #2601

merged 1 commit into from
Dec 13, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Dec 3, 2021 •
edited
Loading

What do these changes do?

Request global slots in batches. This reduces potential time cost when a number of slots are to be allocated.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi requested a review from qinxuye as a code owner December 3, 2021 09:39
@wjsi wjsi added mod: scheduling service to be backported Indicate that the PR need to be backported to stable branch type: enhancement request labels Dec 3, 2021
@wjsi wjsi added this to the v0.9.0a1 milestone Dec 3, 2021
@wjsi wjsi requested a review from hekaisheng as a code owner December 6, 2021 05:15
hekaisheng
hekaisheng approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit fecfe6c into mars-project:master Dec 13, 2021
@wjsi wjsi deleted the enh/batch_apply_slots branch December 13, 2021 06:23
wjsi added a commit to wjsi/mars that referenced this pull request Dec 13, 2021
@wjsi
Use batched request to apply for slots (mars-project#2601)
6b39743
@wjsi wjsi mentioned this pull request Dec 13, 2021
Merged
hekaisheng pushed a commit that referenced this pull request Dec 13, 2021
@wjsi
[BACKPORT] Use batched request to apply for slots (#2601) (#2615)
b06bde5
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 13, 2021
chaokunyang added a commit to chaokunyang/mars that referenced this pull request May 31, 2022
@chaokunyang
PullRequest: 216 Use batched request to apply for slots (mars-project…
c11fe81 
…#2601)

Merge branch cherry-pick-batch-apply-slots of [email protected]:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/216

Signed-off-by: 留宝 <[email protected]>


* Use batched request to apply for slots (mars-project#2601)

# Conflicts:
#	mars/services/scheduling/supervisor/globalslot.py
#	mars/services/scheduling/supervisor/queueing.py
#	mars/services/scheduling/supervisor/tests/test_queue_balance.py
#	mars/services/scheduling/supervisor/tests/test_queueing.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: scheduling service type: enhancement request
Projects
None yet
Milestone
v0.9.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng