Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #3362

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Fix test failures #3362

merged 5 commits into from
Nov 2, 2023

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Oct 2, 2023 •
edited
Loading

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi force-pushed the bugfix/fix_fails branch 2 times, most recently from 12378bc to a84a3fd Compare October 2, 2023 23:49
@wjsi wjsi force-pushed the bugfix/fix_fails branch 6 times, most recently from 30c36ba to 7952144 Compare October 28, 2023 08:59
@wjsi wjsi force-pushed the bugfix/fix_fails branch 2 times, most recently from 314b628 to ede1022 Compare October 29, 2023 09:01
@wjsi wjsi changed the title [WIP] Fix test failures Fix test failures Oct 29, 2023
@wjsi wjsi marked this pull request as ready for review October 29, 2023 10:40
@wjsi wjsi requested a review from a team as a code owner October 29, 2023 10:40
@wjsi wjsi added type: bug Something isn't working to be backported Indicate that the PR need to be backported to stable branch labels Oct 29, 2023
zhongchun
zhongchun approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjsi wjsi merged commit bcc0005 into mars-project:master Nov 2, 2023
17 of 22 checks passed
@wjsi wjsi deleted the bugfix/fix_fails branch November 2, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wubiliang wubiliang wubiliang approved these changes

@zhongchun zhongchun zhongchun approved these changes

Assignees
No one assigned
Labels
to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @zhongchun @wubiliang