Logging clean up #1190
Merged
Logging clean up #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Remove no longer needed Basket, Crate & Pot - AmountResourceBin takes the bintype as a constructor parameter - BinFactory has sole responsibility for creating Bins - EquipmentInventory uses BinFactory for creation - AmountResourceBin just has a single owner instead of 2; remove use of Entity Part of #647
There were too many method in SimLogger with overlapping responsibilities. Theseneed cleaning up before any logging changes are done. Changes: - SimLogger generic open 'log' method is gone and the specific warning, severe & info are used throughout. - Calls to the remaining generic 'log' method with an Actor are reduced - SimLogger no longer takes a Location parameter; relies on Actor. In nearly all cases the location is redundant and not needed. - Explict is Crop which needs the new getContext approach - ExitAirlock & EnterAirlock remove the massive inconsistencies in how logging is used. Uses airlock.getEntityName() instead of dangerous toString methods. Part of #647
None of the Unit classes use a different Nick Name so it is always defaulted to the name property; henc ethe method is redundant. The core of the logic should always use the offical unit name. Changes: - Unit remove the getNickName method - Replace all calls to getNickname with getName Part of #647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appears large but it is actually quite simple changes. Its purpose is to clean up the use of
SimLoggerin preparation of the 2nd phase to replace lovable with NamedEntity. Thus covers the following:Phase 1 of #647