[BUG] (IDM update.exe launching on update check) #1655
Comments
|
Hello, I will need you to open a command prompt window and run the following: Do any of this commands trigger the UAC prompt? |
marticliment
changed the title
|
|
I think the problem is that wingetui wants to run |
|
If I remove |
|
I debugged this in procmon.exe and I found that this update.exe was started by powershell.exe, |
|
This powershell,exe is started by wingetui,exe. Instead of |
WIngetUI should not call any update.exe command, the updater is built-in, it is not an executable... I will take a look at this |
I can confirm this. I also have some IDM products installed. IDM EasyUpdate gets triggered each time I launch wingetGUI. "update self" is an invalid parameter, so it pops up multiple errors. These products were installed standalone, outside of any 'manager'. It's actually verry easy to reproduce. video: |
|
My guess is the culprit is in wingetui\PackageEngine\Managers\powershell.py at line 412. this appears to spawn a shell with the "update self" command, which executes update.exe with the "self" argument, from the shell PATH, which IDM adds. |
|
Yes, this could be it. I thought I had removed that piece of code, maybe it reappeared due to some incorrect git conflict resolution... I am going to add a dummy update.exe file to local path and going to test it, but this should be the cause of the issue. Thanks! |
|
maybe this could be fixed with proper quoting? I'm not a python wiz, but chatGPT suggested this change to me: |
|
No, the issue here is far more basic: this code shouldn't be here, since PowerShell gallery does not support manually updating package indexes. However, it looks as if the previously deleted code reappeared, possibly the cause of a poorly done git conflict resolution. (this then is my fault) |
|
Its indeed weird and unethical on IDM's part. I have UltraCompare, UltraEdit and UltraFinder installed. only Ultrafinder comes with update.exe, yet the updater also finds updates for their other product, but is not supplied in any other product's parent folder. But hey, at least you got a bug/code oversight spotted out of their malpractice. for now i'll just rename the update.exe, I don't use it anyway. Not sure if the path variable is also used for other purposes in the IDM products, so i'll keep that as is. |
Easy to test. In |
I believe the culprit has already been investigated, and found, just not fixed yet... The only call to "update(.exe)" (a.f.a.i.c.t.) is in: anything in the (commandline) path that is named update(.exe) would be called. EDIT
These are my personal assumptions, and do not claim it to be true/or correct in any way. |
skip updateSources() for powershell gallery to fix marticliment#1655
Yes, you are right. When fixing conflicts when merging the PowerShell-testing branch I messed up this, and I did not realize this. This will be fixed on the next release |
Please confirm these before moving forward
Describe your issue
After installing version 2.2.0 Each time I press Refresh on The Updates packages tab this program is started 3 times: c:\Program Files\IDM Computer Solutions\UltraFinder\update.exe and asks for administration permission. Also on initial start, then immediately this update.exe is started.
I have 3 Ultra* programs installed from IDM Computer Solutions. UltraEdit, UltraFInder, UltraCompare.
I have already uninstalled version 2.2.0 and reinstalled it, but still the same behaviour
Steps to reproduce the issue
Press Refresh button
WingetUI Log
Package Managers Logs
Relevant information
none
Screenshots and videos
The text was updated successfully, but these errors were encountered: