HINSTANCE is no longer assigned to nullptr #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cially a pointer (replaced by 0)
martin-olivier
deleted the
37-cant-use-nullptr-for-handle-when-you-dont-know-its-a-pointer
branch
eyalroz
reviewed
Jun 3, 2022
| @@ -89,7 +89,7 @@ class dylib { | |||
| dylib& operator=(const dylib&) = delete; | |||
|
|
|||
| dylib(dylib &&other) noexcept : m_handle(other.m_handle) { | |||
| other.m_handle = nullptr; | |||
| other.m_handle = 0; | |||
There was a problem hiding this comment.
0 is not really much different than nullptr - it assumes HINSTANCE can be initialized by an integer. You might as well keep the nullptr. If you don't want to do something fancier/more complex, you could at least add a comment regarding the assumption somewhere. Maybe even here.
eyalroz
reviewed
Jun 3, 2022
| @@ -215,7 +215,7 @@ class dylib { | |||
| } | |||
|
|
|||
| protected: | |||
| native_handle_type m_handle{nullptr}; | |||
| native_handle_type m_handle{}; | |||
There was a problem hiding this comment.
Now you're making two assumptions: constructible from 0 and default constructible :-P
|
Mhhh to be honest i don't understand your point on that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
HINSTANCEis not assigned tonullptranymore since it's not officially a pointer (replaced by 0)