Fix analysis warnings

- Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in App-vNext#2003.
martincostello · Mar 1, 2024 · 8ac8979 · 8ac8979
1 parent d33ee4e
commit 8ac8979
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/docs/strategies/retry.md b/docs/strategies/retry.md
@@ -710,17 +710,15 @@ var ctsKey = new ResiliencePropertyKey<CancellationTokenSource>("cts");
 var retry = new ResiliencePipelineBuilder()
     .AddRetry(new()
     {
-        OnRetry = args =>
+        OnRetry = async args =>
         {
             if (args.Outcome.Exception is TimeoutException)
             {
                 if (args.Context.Properties.TryGetValue(ctsKey, out var cts))
                 {
-                    cts.Cancel();
+                    await cts.CancelAsync();
                 }
             }
-
-            return ValueTask.CompletedTask;
         }
     })
     .Build();

diff --git a/src/Snippets/Docs/Retry.cs b/src/Snippets/Docs/Retry.cs
@@ -402,17 +402,15 @@ public static void AntiPattern_CancellingRetry()
         var retry = new ResiliencePipelineBuilder()
             .AddRetry(new()
             {
-                OnRetry = args =>
+                OnRetry = async args =>
                 {
                     if (args.Outcome.Exception is TimeoutException)
                     {
                         if (args.Context.Properties.TryGetValue(ctsKey, out var cts))
                         {
-                            cts.Cancel();
+                            await cts.CancelAsync();
                         }
                     }
-
-                    return ValueTask.CompletedTask;
                 }
             })
             .Build();

diff --git a/test/Polly.Specs/Retry/WaitAndRetryForeverAsyncSpecs.cs b/test/Polly.Specs/Retry/WaitAndRetryForeverAsyncSpecs.cs
@@ -86,7 +86,7 @@ public void Should_throw_when_sleep_duration_provider_int_context_timespan_is_nu
     {
         Action policy = () => Policy
                                .Handle<Exception>()
-                               .WaitAndRetryForeverAsync(default(Func<int, Context, TimeSpan>), default(Action<Exception, int, TimeSpan, Context>));
+                               .WaitAndRetryForeverAsync(default, default(Action<Exception, int, TimeSpan, Context>));
 
         policy.Should().Throw<ArgumentNullException>().And
               .ParamName.Should().Be("sleepDurationProvider");