Remove short job #1886
Merged
Remove short job #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove [ShortRunJob] and explicitly use a short job with crank.
costellobot
reviewed
Sep 18, 2024
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://localhost:50001 |
| Device | URL |
|---|---|
| mobile | https://localhost:50001 |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
=======================================
Coverage 68.08% 68.08%
=======================================
Files 110 110
Lines 3014 3014
Branches 441 425 -16
=======================================
Hits 2052 2052
- Misses 951 962 +11
+ Partials 11 0 -11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
[ShortRunJob]and explicitly use a short job with crank.