Add note about Java 21

martinpaljak · Feb 27, 2024 · 5b33e61 · 5b33e61
1 parent 0a755aa
commit 5b33e61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/robot.yml b/.github/workflows/robot.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 8, 11, 17, 21 ]
+        java: [ 8, 11, 17 ] # FIXME: add back 21 once CAPFile is refactored
     name: Java ${{ matrix.java }}
     steps:
       - name: Checkout with submodules

diff --git a/capfile/src/main/java/pro/javacard/capfile/CAPFile.java b/capfile/src/main/java/pro/javacard/capfile/CAPFile.java
@@ -111,6 +111,7 @@ public void store(OutputStream to) throws IOException {
         }
     }
 
+    // FIXME: 21 rightfully complains about this (getComponent leaking this)
     protected CAPFile(InputStream in) throws IOException {
         try (ZipInputStream zip = new ZipInputStream(in)) {
             // All ZIP entries