Migrate to null safety #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this library in a project and implemented the changes needed for this to compile under null safety. Figured I would contribute this back...
|
Resolves issue #7 |
|
Had to make a few changes to your pubspec.yaml to get this to compile correctly. Also note that pubspec.lock is not recommended to be checked in for library repos, only for applications. I also updated the pedantic version and added the non-nullabl exception. That one you may want to mess with, but this forked version now compiles just fine in my application. |
abaire
reviewed
Sep 15, 2022
| this.autoStart = false, | ||
| this.initialBuilder, | ||
| required this.initialBuilder, |
There was a problem hiding this comment.
The README and comment on line 16 should also be updated to reflect this change, or (better) initialBuilder should be nullable and optional to preserve the original behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library in a project and implemented the changes needed for this to compile under null safety. Figured I would contribute this back...