Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jj git push is not working for me on Windows #3322

Open
jyn514 opened this issue Mar 18, 2024 · 5 comments · May be fixed by #3554
Open

jj git push is not working for me on Windows #3322

jyn514 opened this issue Mar 18, 2024 · 5 comments · May be fixed by #3554
Labels
🐛bug Something isn't working 🪟Windows

Comments

@jyn514
Copy link
Collaborator

jyn514 commented Mar 18, 2024 •
edited
Loading

Description

whenever i run jj git push, i get one of the two errors:

  • on WSL: Error: invalid or unknown remote ssh hostkey; class=Ssh (23); code=Certificate (-17)
  • on Windows: Error: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)

Steps to Reproduce the Problem

i have no idea. i don't believe this is related to my .ssh/config, since ssh -F /dev/null [email protected] succeeds. i have the following env variables set on WSL:

; set | grep '^SSH'
SSH_AGENT_PID=48
SSH_AUTH_SOCK=/tmp/ssh-XXXXXXzGR8a4/agent.47

those aren't set on windows, but ssh-agent is somehow working anyway; at least, ssh-add succeeds.

Expected Behavior

jj is able to push to the remote.

Specifications

  • Platform: Linux windows-desktop 5.10.102.1-microsoft-standard-WSL2 Fix readme typo #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
    • Windows 11 Pro 22621.3296
  • Version: jj 0.15.1-bf76080f42f77cad934d9a5202c7b7d29ab2c890 (although this also happened with 0.14)
@PhilipMetzger PhilipMetzger added the 🐛bug Something isn't working label Mar 18, 2024
@gulbanana
Copy link
Collaborator

the second one might be libgit2/libgit2#6612
iirc i’ve worked around this in the past by ensuring my known_hosts does not contain an ed25519 key for github

@MordechaiHadad
Copy link

I am getting the same issue on windows (not WSL):

PS D:\repos\LeadLens> jj git push -c "@-"
Creating branch push-nroqnvwmpzqn for revision @-
Branch changes to push to origin:
  Add branch push-nroqnvwmpzqn to e06c042721af
Error: Failed to authenticate SSH session: ; class=Ssh (23)
Hint: Jujutsu uses libssh2, which doesn't respect ~/.ssh/config. Does `ssh -F /dev/null` to the host work?

@HybridEidolon
Copy link
Contributor

HybridEidolon commented Apr 20, 2024 •
edited
Loading

Similar issue here; I am cloning a repository from a private GitLab service using Windows and the remote ssh key is ed25519, and getting "Error: Fetch failed: failed to set hostkey preference: The requested method(s) are not currently supported; class=Ssh (23)". If I comment out the known_hosts line, I instead get "Fetch failed: failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23)"

@HybridEidolon
Copy link
Contributor

libssh2 error code 23 is LIBSSH2_ERROR_CHANNEL_UNKNOWN which is either "Packet received for unknown channel" or "Channel not found". That's really strange. This seems to affect jj all the way back to 0.7 (which was what cargo installed for some reason). Is libgit2 doing something it shouldn't?

@HybridEidolon
Copy link
Contributor

I've tracked down the issue. The Windows Cryptography Next Generation API backend for libssh2 do not have support for ED25519 and libssh2-sys is defaulting to use it instead of OpenSSL when targeting win32 (either msvc or mingw). libssh2-sys must be compiled with the openssl-on-win32 feature (and vendored-openssl) in order to use the OpenSSL backend.

All distributions of git on windows use a combination of cygwin and git itself which are all compiled to use openssl, which is why it's not a common issue for windows git users. But when using libgit2 directly, this is something to be conscientious of I guess.

HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 21, 2024
@HybridEidolon
git: Always use OpenSSL on win32
bf2d8d7 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change necessitates Windows users building jj to install openssl via vcpkg
for the target triple x64-windows-static-md when building for MSVC, or otherwise
have OpenSSL available at build time. This should also generally work when
building for MinGW, though I did not try it.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 21, 2024
@HybridEidolon
git: Always use OpenSSL on win32
9359703 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change necessitates Windows users building jj to install openssl via vcpkg
for the target triple x64-windows-static-md when building for MSVC, or otherwise
have OpenSSL available at build time. This should also generally work when
building for MinGW, though I did not try it.

Fixes martinvonz#3322
@HybridEidolon HybridEidolon linked a pull request Apr 21, 2024 that will close this issue
Open
4 tasks
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 21, 2024
@HybridEidolon
git: Always use OpenSSL on win32
c6a5c8e 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change necessitates Windows users building jj to install openssl via vcpkg
for the target triple x64-windows-static-md when building for MSVC, or otherwise
have OpenSSL available at build time. This should also generally work when
building for MinGW, though I did not try it.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 21, 2024
@HybridEidolon
git: Always use OpenSSL on win32
811bf5d 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change necessitates Windows users building jj to install openssl via vcpkg
for the target triple x64-windows-static-md when building for MSVC, or otherwise
have OpenSSL available at build time. This should also generally work when
building for MinGW, though I did not try it.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 23, 2024
@HybridEidolon
git: Always use OpenSSL on win32
dac8344 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 23, 2024
@HybridEidolon
git: Always use OpenSSL on win32
a86bc8a 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 24, 2024
@HybridEidolon
git: Always use OpenSSL on win32
fb9ef1c 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue Apr 27, 2024
@HybridEidolon
git: Always use OpenSSL on win32
0c15b40 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue May 2, 2024
@HybridEidolon
git: Always use OpenSSL on win32
6efb2e4 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue May 3, 2024
@HybridEidolon
git: Always use OpenSSL on win32
25edaaf 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue May 8, 2024
@HybridEidolon
git: Always use OpenSSL on win32
c59e79d 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
HybridEidolon added a commit to HybridEidolon/jj that referenced this issue May 12, 2024
@HybridEidolon
git: Always use OpenSSL on win32
89fc574 
By default, libssh2 uses Windows Cryptography Next Generation when targeting
win32. The wincng backend does not support ED25519, which is a widely-used
algorithm among git hosting services, and in some cases may be the only option
on remotes in certain configurations.

This change adds the feature `openssl-on-win32`, enabling the same one in
`libssh2-sys`, and enables it in the CI release flow, ensuring that release
builds are able to communicate with hosts using ED25519.

Fixes martinvonz#3322
@miscoined miscoined mentioned this issue Nov 8, 2024
Open
@martinvonz martinvonz mentioned this issue Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working 🪟Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

git: Always use OpenSSL on win32 HybridEidolon/jj
6 participants
@HybridEidolon @gulbanana @ilyagr @jyn514 @MordechaiHadad @PhilipMetzger