You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
$ jj git clone [email protected]:martinvonz/jj.git
$ cd jj
$ jj git remote rename origin upstream
$ jj status
Warning: Failed to resolve `revset-aliases.trunk()`: Revision "main@origin" doesn't existHint: Use `jj config edit --repo` to adjust the `trunk()` alias.The working copy is cleanWorking copy : uxoupnzt feeefad9 (empty) (no description set)Parent commit: kznzyvnl 1e527dd2 main | cargo: bump serde in the cargo-dependencies group
Expected Behavior
Ideally, renaming the remote would fix the trunk() alias and jj status would emit no warnings.
I presume that the trunk() alias might be arbitrarily complex in the general case. That would make an implementation of an automatic fix difficult. (And it's not obvious whether an automatic fix is desired in the first place.)
If this is the case, emitting the warning when breaking the alias (in this case: when executing jj git remote rename origin upstream) would be IMO more user friendly than the status quo.
As of right, now it's not obvious which command broke the alias. The first time I encountered this behavior, the warning was emitted while adding another remote -- that was confusing.
Description
Renaming a Git remote might break the
trunk()
alias. The warning is printed on a subsequent command rather than on the one that broke the alias.(Not sure if working-as-intended but it was confusing to me.)
Related: #4616.
Steps to Reproduce the Problem & Actual Behavior
Expected Behavior
Ideally, renaming the remote would fix the
trunk()
alias andjj status
would emit no warnings.I presume that the
trunk()
alias might be arbitrarily complex in the general case. That would make an implementation of an automatic fix difficult. (And it's not obvious whether an automatic fix is desired in the first place.)If this is the case, emitting the warning when breaking the alias (in this case: when executing
jj git remote rename origin upstream
) would be IMO more user friendly than the status quo.As of right, now it's not obvious which command broke the alias. The first time I encountered this behavior, the warning was emitted while adding another remote -- that was confusing.
Specifications
The text was updated successfully, but these errors were encountered: