Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add revset filter to "branch list" #1762

Merged
merged 2 commits into from
Jul 2, 2023
Merged

cli: add revset filter to "branch list" #1762

merged 2 commits into from
Jul 2, 2023

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Jun 28, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (src/config-schema.json)
  • I have added tests to cover my changes

ilyagr
ilyagr reviewed Jun 29, 2023
View reviewed changes
src/commands/branch.rs Outdated Show resolved Hide resolved
src/commands/branch.rs Outdated Show resolved Hide resolved
src/commands/branch.rs Show resolved Hide resolved
src/commands/branch.rs Outdated Show resolved Hide resolved
martinvonz
martinvonz reviewed Jun 30, 2023
View reviewed changes
src/commands/branch.rs Outdated Show resolved Hide resolved
ilyagr
ilyagr reviewed Jun 30, 2023
View reviewed changes
src/commands/branch.rs Show resolved Hide resolved
tests/test_branch_command.rs Show resolved Hide resolved
src/commands/branch.rs Outdated Show resolved Hide resolved
@ilyagr ilyagr mentioned this pull request Jul 1, 2023
Closed
ilyagr
ilyagr reviewed Jul 1, 2023
View reviewed changes
src/commands/branch.rs Outdated Show resolved Hide resolved
ilyagr
ilyagr reviewed Jul 1, 2023
View reviewed changes
src/commands/branch.rs Outdated Show resolved Hide resolved
ilyagr
ilyagr approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

I have some comments about comments and tests, they are optional.

I also realized I want another feature, perhaps leave a TODO if you agree? It would also apply to log -r.

yuja added 2 commits July 2, 2023 10:01
@yuja
op_store: make RefTarget return removes/adds as slice, .clone() as ne…
fd007d2 
…eded
@yuja
cli: add revset filter to "branch list"
45ce318 
Typical query would be something like -r 'mine()' or -r 'branches()' to
exclude remote-only branches martinvonz#1136.

The query matches against local targets only. This means there's no way to
select deleted/forgotten branches by -r option. If we add a default revset
configuration, we'll need some way to turn the default off.
@yuja yuja merged commit cefbeba into martinvonz:main Jul 2, 2023
@yuja yuja deleted the push-szsknouyvyyq branch July 2, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyagr ilyagr ilyagr approved these changes

@martinvonz martinvonz martinvonz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuja @martinvonz @ilyagr