Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add plan for non-tracking branches support (RFC) #2074

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Aug 14, 2023

#1136, #1666, #1734

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr
Copy link
Collaborator

ilyagr commented Aug 15, 2023

Thank you for working on this! At a glance, it looks very interesting!

I wanted to warn you not to count on me being able to read this carefully and think about it in the near future, though it might also happen.

@yuja yuja marked this pull request as ready for review August 15, 2023 12:56
@yuja yuja changed the title doc: add plan for non-tracking branches support (WIP) (RFC) doc: add plan for non-tracking branches support (RFC) Aug 16, 2023
Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for working on this complicated topic. Sorry that I haven't gotten around to reviewing it until now. I still haven't had time to think much about the consequences. I'm approving mostly on faith. We can always make adjustments later if we (you, most likely) discover problems.

@yuja yuja merged commit aae9aa4 into martinvonz:main Aug 23, 2023
14 checks passed
@yuja yuja deleted the push-mzzoxuplslux branch August 23, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants