-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Make github.md a bit clearer #2158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
August 24, 2023 23:42
4eac515
to
d30121a
Compare
martinvonz
reviewed
Aug 25, 2023
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
August 25, 2023 18:03
d30121a
to
7ac67a5
Compare
PhilipMetzger
commented
Aug 25, 2023
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
2 times, most recently
from
August 25, 2023 21:52
25e15e9
to
7d2aee2
Compare
PhilipMetzger
commented
Aug 25, 2023
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
August 25, 2023 22:17
7d2aee2
to
6833c68
Compare
martinvonz
reviewed
Aug 27, 2023
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
August 27, 2023 19:55
6833c68
to
c00bb5e
Compare
ilyagr
reviewed
Aug 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip! I have a bunch of optional suggestions; some of them are not even about the text you edited.
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
August 27, 2023 20:22
c00bb5e
to
8a0ed77
Compare
ilyagr
reviewed
Aug 27, 2023
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
September 11, 2023 17:55
8a0ed77
to
4618b17
Compare
4 tasks
This adresses #1989
PhilipMetzger
force-pushed
the
push-woxnvonzlvmr
branch
from
September 26, 2023 21:57
4618b17
to
d645757
Compare
martinvonz
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adresses #1989
Checklist
If applicable: