Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make github.md a bit clearer #2158

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Docs: Make github.md a bit clearer #2158

merged 1 commit into from
Sep 27, 2023

Conversation

PhilipMetzger
Copy link
Collaborator

This adresses #1989

Checklist

If applicable:

  • I have updated the documentation (README.md, docs/, demos/)

docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
@PhilipMetzger PhilipMetzger force-pushed the push-woxnvonzlvmr branch 2 times, most recently from 25e15e9 to 7d2aee2 Compare August 25, 2023 21:52
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip! I have a bunch of optional suggestions; some of them are not even about the text you edited.

docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
docs/github.md Show resolved Hide resolved
docs/github.md Outdated Show resolved Hide resolved
@PhilipMetzger PhilipMetzger merged commit e158423 into main Sep 27, 2023
15 checks passed
@PhilipMetzger PhilipMetzger deleted the push-woxnvonzlvmr branch September 27, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants