Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: preserve HEAD when possible #2331

Merged
merged 1 commit into from
Nov 1, 2023
Merged

git: preserve HEAD when possible #2331

merged 1 commit into from
Nov 1, 2023

Conversation

isinyaaa
Copy link
Collaborator

@isinyaaa isinyaaa commented Oct 4, 2023 •
edited
Loading

Closes: #2210

Depends on: #2330

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja
yuja reviewed Oct 4, 2023
View reviewed changes
lib/src/git.rs Outdated Show resolved Hide resolved
lib/src/git.rs Outdated Show resolved Hide resolved
@isinyaaa isinyaaa force-pushed the fix-colocated-head branch 2 times, most recently from 89ee21e to bfa0e39 Compare October 29, 2023 23:32
@isinyaaa isinyaaa requested a review from yuja October 30, 2023 00:34
yuja
yuja reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

cli/tests/test_checkout.rs Outdated Show resolved Hide resolved
@isinyaaa isinyaaa requested a review from yuja October 30, 2023 11:18
yuja
yuja approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@isinyaaa isinyaaa merged commit 749d8bb into martinvonz:main Nov 1, 2023
14 checks passed
@isinyaaa isinyaaa deleted the fix-colocated-head branch November 1, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz left review comments

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: preserve current Git branch in co-located repo when possible
3 participants
@isinyaaa @yuja @martinvonz