Teach jj squash --from/--into, deprecate jj move
#3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyously
reviewed
Mar 11, 2024
joyously
reviewed
Mar 11, 2024
This was proposed by @Brixy in #2882 a while ago. There seems to be pretty strong consensus that it's a good idea. I've copied the added test cases from `test_move_command.rs`, just replacing `move` by `squash`, `--to` by `--into`, and deleting the test of a no-arg invocation (`jj move` fails, `jj squash` does not - it defaults to squashing into the parent).
Per discussion in #2882. `jj squash` now has all the functionality.
martinvonz
force-pushed
the
push-qmouznkumpmz
branch
from
f3b4261
to
e97c7a4
Compare
|
I mentioned this PR on Discord and heard only votes for it, so I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md