Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

describe: allow updating the description of multiple commits #3828

Merged
merged 1 commit into from
Aug 4, 2024
Merged

describe: allow updating the description of multiple commits #3828

merged 1 commit into from
Aug 4, 2024

Conversation

bnjmnt4n
Copy link
Collaborator

@bnjmnt4n bnjmnt4n commented Jun 4, 2024 •
edited
Loading

If multiple commits are provided, the description of each commit will be combined into a single file for editing.

Closes #3120.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • [NA] I have updated the documentation (README.md, docs/, demos/)
  • [NA] I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bnjmnt4n bnjmnt4n mentioned this pull request Jun 4, 2024
Closed
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch from 088ea1a to 3a92556 Compare June 4, 2024 22:19
yuja
yuja reviewed Jun 5, 2024
View reviewed changes
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch 3 times, most recently from a12664b to a1b718e Compare June 6, 2024 16:17
yuja
yuja reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cli/src/commands/describe.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/tests/test_describe_command.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch 4 times, most recently from 9e568a2 to fd71d62 Compare June 14, 2024 13:06
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch 4 times, most recently from 80c486a to 1bc9de0 Compare July 5, 2024 09:46
@emilazy emilazy mentioned this pull request Jul 16, 2024
Closed
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch 3 times, most recently from 7e40875 to a516a34 Compare July 25, 2024 14:04
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-mtypsntrzvuk branch 2 times, most recently from ae7c7c5 to 8721f7a Compare July 25, 2024 19:12
yuja
yuja reviewed Jul 26, 2024
View reviewed changes
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Show resolved Hide resolved
cli/src/description_util.rs Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
@ilyagr ilyagr mentioned this pull request Jul 30, 2024
Draft
3 tasks
@ilyagr
Copy link
Collaborator

ilyagr commented Jul 31, 2024

BTW, I started using this PR myself, and it is (unsurprisingly) incredibly convenient. Thank you!

yuja
yuja approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this feature.

There are minor things that can be improved, but it's probably better to not make this commit bigger. Please feel free to leave some nits unchanged and address separately. Add TODO comments as needed.

cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/description_util.rs Show resolved Hide resolved
cli/src/description_util.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
cli/src/commands/describe.rs Outdated Show resolved Hide resolved
@bnjmnt4n
describe: allow updating the description of multiple commits
24131d8 
If multiple commits are provided, the description of each commit
will be combined into a single file for editing.
@ilyagr ilyagr mentioned this pull request Aug 4, 2024
Open
@bnjmnt4n bnjmnt4n merged commit 35b04f4 into main Aug 4, 2024
29 checks passed
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n/push-mtypsntrzvuk branch August 4, 2024 18:06
@ilyagr ilyagr mentioned this pull request Aug 4, 2024
Merged
@InCogNiTo124 InCogNiTo124 mentioned this pull request Aug 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max397574 max397574 max397574 left review comments

@ilyagr ilyagr ilyagr left review comments

@martinvonz martinvonz martinvonz left review comments

@arxanas arxanas arxanas left review comments

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: support for bulk-editing of commit descriptions
6 participants
@bnjmnt4n @ilyagr @yuja @arxanas @martinvonz @max397574