-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git_backend: Support shallow git repositories #4448
Conversation
95b8983
to
9a7f715
Compare
Only did some light manual testing. Unsure how to write a proper test for this, so if anyone has any ideas I am all ears :) Do we want to specially render shallow commits? Right now they will just have the virtual root as their parent |
2f535ba
to
4d117b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits and some points for further discussion. I also think the initial PR description was good, but we don't really have guidelines here.
4d117b0
to
6c47a30
Compare
e4d43f1
to
6ed25c6
Compare
6ed25c6
to
7e9bfea
Compare
Okay this is ready for proper review now. I'm leaving deepening/unshallowing for a separate issue (will open an issue for that after this is merged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG after addressing Yuya's nits.
2b5f2e5
to
361b203
Compare
469a35c
to
c3adbe3
Compare
c3adbe3
to
64a2221
Compare
Fixes #675
Checklist
If applicable:
CHANGELOG.md