Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Refactor out get_fetch_remotes into git_util.rs #4768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 13, 2024

  1. cli: Refactor out get_fetch_remotes into git_util.rs

    Similarly to `git_fetch`, this will be used in `jj git sync`, so
    moving this out to maintain the same behaviour across `fetch` command and `sync`.
    
    * Refactor out `get_fetch_remotes` to `git_util.rs`.
    * inline the different `get_*_remote*` functions into `get_fetch_remotes`;
      The resulting function is still small enough to be easily readable.
    * Move `get_single_remote` into `git_util.rs` and update call sites.
    * Use common FetchArgs to pass arguments both to `get_fetch_remotes` and `git_fetch`
    * Update use references
    
    All tests still pass.
    
    Issue: #1039
    essiene committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c1da3c8 View commit details
    Browse the repository at this point in the history