Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webview object in "About" dialogue with text object and clickable text link #203

Closed
robinpaulson opened this issue Jun 17, 2017 · 2 comments
Labels

Comments

@robinpaulson
Copy link
Contributor

Before fixing #202 we should perhaps first replace the "webview" object with a simple clickable text field. Webview isn't necessary for a few hyperlinks.

Textview looks like it will be suitable:
https://stackoverflow.com/questions/2734270/how-do-i-make-links-in-a-textview-clickable#2746708

@robinpaulson robinpaulson added this to the v1.6 milestone Jun 17, 2017
@splitowo
Copy link
Contributor

splitowo commented Mar 8, 2018

Hi there,
I have removed the WebView and put the text directly as a dialog message. The string is relocated to strings.xml.

splitowo@ea81b87

I couldn't reproduce #202, the links always opened in the browser for me, but if there is no longer WebView, this should be resolved, I suppose.

Below is the comparison after(London) and before(Melbourne) the change. The layout stays pretty much the same, the hyperlinks are clickable.
screenshot_20180308-231249
screenshot_20180308-231307

Let me know if that change is ok to pull

@robinpaulson
Copy link
Contributor Author

Fixed with #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants