Replace the "About" WebView with a FragmentDialog #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jackzaty3@ |
|
Excellent. The v1.9 release is going to be pretty impressive! |
|
Hi @splitowo I'm afraid another commit I merged today means your PR will no longer merge. I don't have the skills to fix it, perhaps you could take a look? I'm sure it's simple, at a guess only a few lines of code. Cheers, Robin |
|
Thanks for the message. I rebased my commit on top of your master branch, it should now merge with no issues |
This was referenced Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code relates to the #203 issue. WebView has been replaced with a regular TextView inside FragmentDialog. Hardcoded dialog body is now in strings.xml and can be translated.
This type of dialog is kept alive in case of screen orientation change (discussed in #274). Links are functional and open in an internet browser.