Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow picking City when multiple results available w/o GPS #259

Closed
troyengel opened this issue Jan 4, 2018 · 8 comments
Closed

Comments

@troyengel
Copy link

troyengel commented Jan 4, 2018

For some cities there are multiple results when searching by text name, like this example:

Forecastie appears to just pick the first one in the list, we should present the user a popup to choose which one. This is difficult visually, because the OWM data doesn't appear to list Locality (State, e.g.), they simply rely on Geo coordinates that are painful to "just know" for any average user. One of these example results is not in USA of course, so we have a larger problem as the result list crosses national boundaries.

Not sure how to visually represent in the app this other than a popup listing the choices with the geo coordinates, and expect the user to go look them up for themselves? Maybe if the popup linked those coordinates to launch Google Maps? (I can take them as-is from OWM and maps.google.com finds them no problem) Something is better than just randomly picking the first result...

Note: this is with Location / GPS disabled, just using the search eyeglass method

(edit: sorry my example didn't make sense there when I said "outside the US" - if you search 'San Antonio' that happens, drop the US. My mistake as I was writing this.)

@robinpaulson
Copy link
Contributor

Yep, again decent reverse-geocoding will fix this.

@andrewmattie
Copy link

Would something like this work? https://imgur.com/a/qgeVeyO

@troyengel
Copy link
Author

troyengel commented Jan 27, 2019

I think that looks really cool! I would suggest adding the country in the title shown as well - using the same example as above without the country ( https://openweathermap.org/find?q=san+antonio ) we get 5 different countries which appear in the results, seems like a good move to include it visually? neat. :)

@andrewmattie
Copy link

I'm glad you like it! Appending the country to the city is something I had meant to do so thanks for the reminder. I've gone a head and made the change. It makes it a lot easier to identify the city at a glance. https://imgur.com/a/GvivOgb

@robinpaulson
Copy link
Contributor

This is really excellent, @andrewmattie . If you want to make a PR, I will be glad to add this to the app. Including the country would be good too.

@robinpaulson
Copy link
Contributor

Duplicate of #183

@robinpaulson robinpaulson marked this as a duplicate of #183 Feb 1, 2019
@atpage
Copy link

atpage commented Apr 8, 2019

Would something like this work? https://imgur.com/a/qgeVeyO

In 1.10.3, the maps in the Locations selector all come up blank for me. Any suggestions, or should I submit a separate bug?

@robinpaulson
Copy link
Contributor

@atpage Could this be an internet connectivity problem? If you still can't get it to work, then yes, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants