Use cityId for weather and add location picker when searching #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 23, 2019 16:05
This was referenced Feb 1, 2019
|
Hi @andrewmattie it's great to see this PR, it fixes a set of annoying and discouraging bugs. I'm not slavishly committed to Codacy's standards, it is mostly advice, but would you be able to take a look through their report into the PR and see what you think? Cheers |
|
@robinpaulson Sure, I'll go ahead and implement the fixes. They seem to be simple changes. |
|
OK, that's looking better now. The previous release appears to be working fine; a few days and I'll release 1.9 with the 3 queued PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Detect Location to use cityId instead of name which allows for the correct city's weather to be displayed (#266).
Added dialog when searching for a location when there are multiple results (#259).