Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending nick out of sequence can cause exceptions #235

Closed
qq99 opened this issue May 25, 2014 · 1 comment · Fixed by #236
Closed

Sending nick out of sequence can cause exceptions #235

qq99 opened this issue May 25, 2014 · 1 comment · Fixed by #236

Comments

@qq99
Copy link
Contributor

qq99 commented May 25, 2014

Here's a sample stream:

25 May 21:10:00 - SEND: NICK echoplexion                                        
25 May 21:10:00 - SEND: USER echoplexus using nodebot 8 * :echoplexus IRC proxy 
25 May 21:10:00 - SEND: NICK Anonymous                                          
25 May 21:10:01 - Unhandled message: { prefix: 'leguin.freenode.net',           
  server: 'leguin.freenode.net',                                                
  command: 'rpl_luserunknown',                                                  
  rawCommand: '253',                                                            
  commandType: 'reply',                                                         
  args: [ 'echoplexion', '10', 'unknown connection(s)' ] }                      
25 May 21:10:01 - SEND: JOIN #javascript                                        
25 May 21:10:01 - MODE:echoplexion sets mode: +i                                
25 May 21:10:06 - SEND: NICK echoplexion1                                       
25 May 21:10:06 - Unhandled message: { prefix: 'leguin.freenode.net',           
  server: 'leguin.freenode.net',                                                
  command: '470',                                                               
  rawCommand: '470',                                                            
  commandType: 'normal',                                                        
  args:                                                                         
   [ 'echoplexion',                                                             
     '#javascript',                                                             
     '##javascript',                                                            
     'Forwarding to another channel' ] }                                        
>> /echoplexus/node_modules/irc/lib/irc.js:637                                  
>>                     throw err;                                               
>>                           ^                                                  
>> TypeError: Cannot read property 'users' of undefined                         
>>   at Client.<anonymous> (/echoplexus/node_modules/irc/lib/irc.js:412:28)     
>>   at Client.EventEmitter.emit (events.js:95:17)                              
>>   at /echoplexus/node_modules/irc/lib/irc.js:634:22                          
>>   at Array.forEach (native)                                                  
>>   at Socket.<anonymous> (/echoplexus/node_modules/irc/lib/irc.js:631:15)     
>>   at Socket.EventEmitter.emit (events.js:95:17)                              
>>   at Socket.<anonymous> (_stream_readable.js:746:14)                         
>>   at Socket.EventEmitter.emit (events.js:92:17)                              
>>   at emitReadable_ (_stream_readable.js:408:10)                              
>>   at emitReadable (_stream_readable.js:404:5)                                
>>   at readableAddChunk (_stream_readable.js:165:9)                            
>>   at Socket.Readable.push (_stream_readable.js:127:10)                       
>>   at TCP.onread (net.js:526:21)                                              

If I remove any call to client.ircClient.send "NICK", nick it's all good. I believe it's be cause I'm not properly connected yet before I try to send the nick

@qq99
Copy link
Contributor Author

qq99 commented May 25, 2014

Further, seems to be related to me being banned on the channel. line 433 presents a similar error

osslate pushed a commit that referenced this issue May 29, 2014
Fixes #235 type error where channel does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant