Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't blow up on 'No such nick/channel' and showErrors before blowing up! #107

Closed
wants to merge 2 commits into from

Conversation

cjstewart88
Copy link

  • Don't blow up on err_nosuchnick, catch it and log it.
  • It's a little easier to debug when we throw the pretty errors before blowing up.

@jakswa
Copy link

jakswa commented Sep 14, 2012

👍 I'd like to see this as well, or at least some variation of it.

@quentinxs
Copy link
Contributor

cjstewart88: all this extra code is unnecessary. The culprit is a single line self.emit('error', message);. This is what is making the client "blow up", as you say. All I did was change that line to self.emit('ircError', message);, and voila! It doesn't throw any more exceptions from IRC error responses.

@cjstewart88
Copy link
Author

We ended up noticing that a well, forgot to update this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants