-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for use_strict #228
Conversation
use unicode escapes to allow node --use_strict
"\033" should be "\u001b" and "\1" should be "\u0001" |
Good point, the 033 is "esc" in octal and unicode escaping is in hex. |
I've updated this patch branch, raising the attention of the master authors is another question. |
In all likelihood, it isn't going to happen. If someone wants to fork and maintain a master that accepts a bunch of these PR fixes, that'd be nice. |
imo -1, --use_strict is the stupidest flag known to mankind. |
@jesusabdullah Don't litter issues with random bullshit please. |
The religious polarization that use_strict brings out is amazing -- I'm just looking for some simple ways to improve security of imported packages. I'm working on allowing Node-RED to support use_strict, so would definitely consider maintaining any required branches. |
@tedgoddard At this point, I'd be looking at other projects. node-irc doesn't seem alive anymore. |
Thanks! |
use unicode escapes to allow node --use_strict