Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for use_strict #228

Merged
merged 2 commits into from
May 29, 2014
Merged

support for use_strict #228

merged 2 commits into from
May 29, 2014

Conversation

tedgoddard
Copy link
Contributor

use unicode escapes to allow node --use_strict

use unicode escapes to allow node --use_strict
@awwright
Copy link

awwright commented May 6, 2014

"\033" should be "\u001b" and "\1" should be "\u0001"

@tedgoddard
Copy link
Contributor Author

Good point, the 033 is "esc" in octal and unicode escaping is in hex.

@tedgoddard
Copy link
Contributor Author

I've updated this patch branch, raising the attention of the master authors is another question.

@katanacrimson
Copy link
Contributor

In all likelihood, it isn't going to happen. If someone wants to fork and maintain a master that accepts a bunch of these PR fixes, that'd be nice.

@jfhbrook
Copy link

imo -1, --use_strict is the stupidest flag known to mankind.

@katanacrimson
Copy link
Contributor

@jesusabdullah Don't litter issues with random bullshit please.

@tedgoddard
Copy link
Contributor Author

The religious polarization that use_strict brings out is amazing -- I'm just looking for some simple ways to improve security of imported packages. I'm working on allowing Node-RED to support use_strict, so would definitely consider maintaining any required branches.

@katanacrimson
Copy link
Contributor

@tedgoddard At this point, I'd be looking at other projects. node-irc doesn't seem alive anymore.

osslate pushed a commit that referenced this pull request May 29, 2014
fix support for use_strict
@osslate osslate merged commit 833190d into martynsmith:master May 29, 2014
osslate pushed a commit that referenced this pull request May 29, 2014
@tedgoddard
Copy link
Contributor Author

Thanks!

@tedgoddard tedgoddard deleted the patch-1 branch May 29, 2014 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants