Implement chanmode params. #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very similar to #145. |
| if (channel.users[user].indexOf(self.prefixForMode[mode]) === -1) | ||
| channel.users[user] += self.prefixForMode[mode]; | ||
|
|
||
| self.emit('+mode', message.args[0], message.nick, mode, user, message); |
There was a problem hiding this comment.
It is important that we still emit these events(+mode and -mode)
|
Tests please |
Closed
|
Added tests. |
Timer
force-pushed
the
master
branch
5 times, most recently
from
54a043d
to
c4e5f81
Compare
|
Rebased to remove merge commits, per request of @vBm on IRC. |
|
Sorry if it sound as a request, it was just merely a suggestion. On Thu, Apr 16, 2015 at 8:57 PM, Joe Haddad [email protected]
|
…erver. Add new key `modeParams` to the channel object, which has keys corresponding to the modes in `mode` that contain the parameter(s) as an array.
…elay the event but don't modify or add to a user. This commonly happens in a channel with +u (auditorum).
|
Looks great. Thanks for this! I manually rebased this and merged it in ee5c550 |
|
Cool @jirwin! I would've rebased if you asked. |
This was referenced Jan 29, 2016
Closed
This was referenced Mar 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this pull request to gain feedback and thoughts.
Once approved, I'll write up a set of tests to ensure it all works and no bugs will arise from the changes.