Properly handle changing user mode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just merged this change (sorry about being so slow on things) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no hooking into mode changes for dealing with changes in ops and such.
There is still a case which this code doesn't handle. I wasn't sure what you thought. If I +o (op) someone, then +v (voice) them, then -o them.. they're still voiced. It seems to me the best way to do this would be some sort of sorted list, but that seems a bit heavy. Perhaps a string of '@+' which, is altered on mode change? Seems like it would make the code heavier. This at least solves my use case (detecting op/deop). Will happily change the patch if you have other preferences.