fix(ping timeouts): When a ping timeout is detected properly destroy … #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the existing connection before making a new one.
|
This should fix #449. |
This was referenced Mar 10, 2016
|
Not sure this is fixed - when running the latest version of master, my error-0.log was filled with: |
|
It just starts pinging after SEND: MODE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the existing connection before making a new one.
Previously the connection wasn't being closed properly as the the
closeevent on the socket was just being emitted instead of actually closing the connection. This caused the client to open a new, duplicate connection on reconnect, instead of replacing the existing connection.