fix localstorage availability check

[Otouto]

Table of Contents

• Description
• Motivation and Context
• How Has This Been Tested?
• Types of changes
• Checklist:

Description

Here is the problem if one try to run code on site with disabled access to cookie/localstorage/sessionstorage:

Motivation and Context

We use react-ab-test on our site and want our code running even if localstorage disabled.

How Has This Been Tested?

Run code after fix in browser with disabled access to localstorage and everything works just fine.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[moretti]

Good catch!

We could probably remove the whole if block, as localStorage.setItem is already surrounded by a try...catch, so should it fall back to noopStore when localstorage is not available. 🤔

react-ab-test/src/Experiment.jsx

Lines 15 to 25 in 7e14e58

	try {
	let key = '__pushtell_react__';
	window.localStorage.setItem(key, key);
	if (window.localStorage.getItem(key) !== key) {
	store = noopStore;
	} else {
	window.localStorage.removeItem(key);
	store = window.localStorage;
	}
	} catch (e) {
	store = noopStore;

Let's keep it for now. I'll merge it and create a new release. Thanks!

[moretti]

Released in v2.1.2

[Otouto]

Agreed, if block here is unnecessary.
Thank you for the fast merge and release 💪