Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the posibility to show debugger in production builds #5

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

jalopez
Copy link

@jalopez jalopez commented Jan 30, 2019

Table of Contents

Description

Add a new method in the debugger (setDebuggerAvailable) that allows a developer to override the default setting that makes the debugger unavailable in production builds

Motivation and Context

There are some scenarios where a developer could want to have the debugger enabled in a production build, or change this behaviour at runtime (for instance, have it enabled in an integration environment but disabled in production one).

Fixes: #3, pushtell#49

How Has This Been Tested?

It is a non-breaking change tested with new unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@moretti moretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Javier 👋Thank you for your PR!
Looks great, the only problem that I can see is that the production build will be slightly bigger, since the minifier won't strip out deadend code, but I think it's fine, the debugger is relatively small.

Happy to merge it and publish a new release! 🎉

@moretti moretti merged commit 8d96b5b into marvelapp:master Feb 4, 2019
@jalopez jalopez deleted the override-debugger-enable branch February 7, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable DebuggerPanel in Production
2 participants