Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hwdec option #21

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add hwdec option #21

merged 2 commits into from
Jul 6, 2022

Conversation

NicolaSmaniotto
Copy link
Collaborator

This adds the option for the user to choose a value for the --hwdec= parameter for mpv subcalls.

The default is kept "no", as it currently is.

From my testing, it can be enabled without issues because mpv is able to gracefully fall back to software decoding.

I personally set it to auto-safe, and it almost halves the time to generate the thumbnails (of course, for encoders supported by my processor).

No links in markdown code blocks
@marzzzello
Copy link
Owner

Thanks!
It seems to make no difference for my CPU though (i7-7500U)

@marzzzello marzzzello merged commit e732ffb into marzzzello:master Jul 6, 2022
@NicolaSmaniotto
Copy link
Collaborator Author

It seems to make no difference for my CPU though (i7-7500U)

This is strange, do you see the hardware decoder when pressing I?

Like this:
Screenshot_20220706_091911

@marzzzello
Copy link
Owner

Yes, it also shows vaapi. The duration for thumbnail generation stays the same.
I'm on mpv 0.34.1-4 on Arch Linux. Log doesn't show anything useful.

@NicolaSmaniotto
Copy link
Collaborator Author

I see. Maybe your processor is already powerful enough to move the bottleneck elsewhere.

My 4th gen i5 certainly needs the help.

Have a nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants