Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Purchase cleanup #272

Merged
merged 8 commits into from
May 15, 2020
Merged

🧹 Purchase cleanup #272

merged 8 commits into from
May 15, 2020

Conversation

phatblat
Copy link
Member

  • Rename purchase parameter, set default to false
  • Use AppLibrary in Purchase command
  • Format source
  • Enable swiftlint autocorrect and format on build

@phatblat phatblat added this to the 1.7 milestone May 15, 2020
houndci-bot
houndci-bot reviewed May 15, 2020
View reviewed changes
MasKitTests/Network/TestURLSessionDelegate.swift Outdated
@@ -13,7 +13,8 @@ class TestURLSessionDelegate: NSObject, URLSessionDelegate {
func urlSession(_: URLSession,
didReceive challenge: URLAuthenticationChallenge,
completionHandler: (URLSession.AuthChallengeDisposition,
URLCredential?) -> Void) {
URLCredential?) -> Void) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

@phatblat phatblat merged commit 38f20a8 into master May 15, 2020
@phatblat phatblat deleted the purchase-cleanup branch May 15, 2020 04:05
@phatblat phatblat mentioned this pull request May 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@phatblat @houndci-bot