🐛 Account for missing JSON fields in search results #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 6, 2020
| do { | ||
| lookup = try storeSearch.lookup(app: appId) | ||
| } catch { | ||
| let maserror = error as! MASError |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
| expect(searchList.resultCount) == 39 | ||
| expect(searchList.results.count) == 39 | ||
| } catch { | ||
| let maserror = error as! MASError |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
| init(from fileName: String) { | ||
| let fileURL = Bundle.url(for: fileName)! | ||
| print("fileURL: \(fileURL)") | ||
| try! self.init(contentsOf: fileURL, options: .mappedIfSafe) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
Generated by 🚫 Danger |
Bundle.url(for:)
# Conflicts: # MasKitTests/Formatters/AppListFormatterSpec.swift
No longer needed as of Quick 3
phatblat
force-pushed
the
search-json
branch
from
3600fcd
to
d217938
Compare
Merged
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where some search terms cause mas to crash with the message "Error: Unable to parse response JSON". This is due to some search results not containing entries for the following keys:
fileSizeBytesformattedPriceprice(normally present, but "Free" when no cost)Fixes #284