Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments & in documentation #539

Closed
wants to merge 3 commits into from

Conversation

rgoldberg
Copy link
Contributor

Fix typos in comments & in documentation

Resolves #538

Partial mas-cli#538

Signed-off-by: Ross Goldberg <[email protected]>
Resolves mas-cli#538

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Sep 16, 2024
tonyarnold
tonyarnold previously approved these changes Sep 16, 2024
Copy link
Contributor

@tonyarnold tonyarnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Resolves mas-cli#538

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Copy link
Contributor Author

@tonyarnold Thanks. I just pushed one minor extra fix for another typo in another comment to this PR. Once the checks are redone, can you make an approving review so the PR can be merged? Thanks again.

@rgoldberg
Copy link
Contributor Author

@tonyarnold The lint check is failing because of existing code (not because of changes from this PR).

I fixed the lint error in an earlier PR (#537), which passed its tests.

Can you review that PR so it can be merged into main?

Once it's merged, I'll rebase this PR off the new main so this won't fail its lint check. After this completes its lint check, then you can approve this rebased PR from a review so it can be merged, too.

Thanks again.

@rgoldberg rgoldberg self-assigned this Sep 16, 2024
@rgoldberg rgoldberg added this to the 1.8.7 milestone Sep 16, 2024
@rgoldberg rgoldberg closed this Oct 5, 2024
@rgoldberg rgoldberg deleted the fix-typos branch October 5, 2024 23:45
@rgoldberg rgoldberg removed their assignment Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos in comments & in documentation
2 participants