Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix for deprecated @rx.cached_var #8

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

albertsola
Copy link
Contributor

@albertsola albertsola commented Jul 31, 2024

@rx.cached_var has been deprecated in reflex v0.5.6

Changes:

  • Updated LocalAuthState and local demo to use @rx.var(cache=True).
  • Add a refresh interval of 10 minutes for cached variables

Copy link
Owner

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change 🎉

I'm going to hold off merging it until 0.5.9 is released because there is a bug in @rx.var(cache=True) where it doesn't get the initial value properly which was fixed today, but hasn't been released yet.

If this isn't merged by next friday, drop a ping here as a reminder 😉

@albertsola
Copy link
Contributor Author

Hi @masenf this is the Friday reminder :)

@masenf
Copy link
Owner

masenf commented Aug 2, 2024

Sorry for the miss communication, I was referring to next Friday 8/9 (as opposed to this Friday - today). Basically need to wait until 0.5.9 is released with reflex-dev/reflex#3726

I appreciate the enthusiasm though 😀

@masenf masenf merged commit cd66cfa into masenf:main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants