Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle And filter expired tasks #17

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Handle And filter expired tasks #17

merged 3 commits into from
Dec 5, 2023

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Dec 1, 2023

  • Expose if a Task is expired or not according to his started and expiration strategy.
  • Add Combine operator to filter expired task
  • Add Combine operator to scope a suscription into a Task and bulk apply removeExpired && removeDuplicates
  • Improve EraseToEmptyTask generics parameters

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (488b802) 93.82% compared to head (d88d3d4) 93.92%.

Files Patch % Lines
Sources/Publishers/Publishers.RemoveExpired.swift 88.00% 3 Missing ⚠️
Sources/Task/KeyedTask.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   93.82%   93.92%   +0.09%     
==========================================
  Files          38       40       +2     
  Lines        2074     2204     +130     
==========================================
+ Hits         1946     2070     +124     
- Misses        128      134       +6     
Flag Coverage Δ
ios 93.78% <95.41%> (+0.10%) ⬆️
mac 93.92% <95.41%> (+0.09%) ⬆️
tv 93.92% <95.41%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianvarela sebastianvarela merged commit 010fbe2 into master Dec 5, 2023
2 of 3 checks passed
@sebastianvarela sebastianvarela deleted the expired_tasks branch December 5, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants