Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error #255

Closed
GiladSchneider opened this issue Jul 12, 2024 · 2 comments
Closed

Fix build error #255

GiladSchneider opened this issue Jul 12, 2024 · 2 comments
Assignees
@alexwillingham @AykhanAhmadli
Milestone
Euphrates

Comments

@GiladSchneider
Copy link
Contributor

GiladSchneider commented Jul 12, 2024 •
edited
Loading

Our builds were failing because of:
ERR_PNPM_FETCH_404  GET https://registry.npmjs.org/ottehr-utils[:](https://registry.npmjs.org/ottehr-utils:) Not Found - 404

we merged #256 as a temporary solve, but need to figure out why this is happening and push a real solution.

The original problem was introduced in a164bca#diff-571d7c5f092e15732ebc9c3ad10699a61949858650a6e4b8303ad1fb4b26488c
saewitz added a commit that referenced this issue Jul 15, 2024
@saewitz
potential update for #255
e954d67
saewitz added a commit that referenced this issue Jul 15, 2024
@saewitz
Revert "potential update for #255"
9d7c849 
This reverts commit e954d67.
AykhanAhmadli pushed a commit that referenced this issue Jul 15, 2024
@saewitz @AykhanAhmadli
potential update for #255
c3c0fc4 
test builds

Revert "potential update for #255"

This reverts commit e954d67.

test builds

test builds

test builds

test

test

testing

testing

test

test

Revert "testing"

This reverts commit 1e8145d.

test

test

test

test

test

test

test
GiladSchneider pushed a commit that referenced this issue Jul 15, 2024
@saewitz
potential update for #255 (#256)
3ed9e64 
test builds

Revert "potential update for #255"

This reverts commit e954d67.

test builds

test builds

test builds

test

test

testing

testing

test

test

Revert "testing"

This reverts commit 1e8145d.

test

test

test

test

test

test

test
@GiladSchneider GiladSchneider changed the title Fix 404 build error Fix build error Jul 17, 2024
@GiladSchneider GiladSchneider mentioned this issue Jul 25, 2024
Closed
@GiladSchneider GiladSchneider added this to the Euphrates milestone Jul 25, 2024
@saewitz
Copy link
Contributor

saewitz commented Jul 25, 2024

We have had this issue for a few weeks. It started with this PR I think: #234 I have undone the changes for each file from that PR and it did not resolve the issue. It is likely an issue with our pnpm setup. We have some local packages, and it's trying to find them on npm registry but we haven't published these packages on it. This issue was partially resolved in #256 so it works locally, but we are still getting the error on GitHub Actions.

@alexwillingham alexwillingham self-assigned this Jul 25, 2024
@GiladSchneider
Copy link
Contributor Author

Tested and pnpm i is working, along with pnpm build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwillingham alexwillingham

@AykhanAhmadli AykhanAhmadli

Labels
None yet
Projects
Ottehr Product
Status: Ready For Release
Milestone
Euphrates
Development

No branches or pull requests
4 participants
@alexwillingham @saewitz @AykhanAhmadli @GiladSchneider